direct: Migrate crd for v1beta1 BigQueryTable #4348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhdle-sso
force-pushed
the
bigquerytable_migrate
branch
5 times, most recently
from
ad23f87 to
67c8677
Compare
anhdle-sso
changed the title
yuwenma
reviewed
Apr 15, 2025
...nsions.k8s.io_v1_customresourcedefinition_bigquerytables.bigquery.cnrm.cloud.google.com.yaml
Show resolved
Hide resolved
...nsions.k8s.io_v1_customresourcedefinition_bigquerytables.bigquery.cnrm.cloud.google.com.yaml
Show resolved
Hide resolved
...nsions.k8s.io_v1_customresourcedefinition_bigquerytables.bigquery.cnrm.cloud.google.com.yaml
Show resolved
Hide resolved
yuwenma
changed the title
|
/approve Looks good. Could you fix the presubmit? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anhdle-sso
force-pushed
the
bigquerytable_migrate
branch
from
df36eca to
24c2444
Compare
Fixed, all presubmit passed |
|
/lgtm |
google-oss-prow
bot
merged commit 35451be
into
GoogleCloudPlatform:master
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Fixes #
Tests you have done
make ready-prto ensure this PR is ready for review.